Date: Thu Nov 06 2003 - 19:42:38 EST
Hi Don,
It's nice to hear that final release is comming soon.
I've checked out current version from CVS and after
few hours of code changes sucessfuly compiled my
aplication. Till now I used modified version from April 2003.
Application works almost as good as previously.
I've found many of my changes in your sources
- thanks a lot. But there are still some problems:
1 . Length class is not serializable so OMDistance
is also not serializable. My workaround was:
protected transient Length distUnits = Length.NM;
private void writeObject(ObjectOutputStream stream) throws IOException {
stream.defaultWriteObject();
stream.writeObject(distUnits.getAbbr());
}
private void readObject(ObjectInputStream stream)
throws IOException, ClassNotFoundException {
stream.defaultReadObject();
distUnits = Length.get((String)stream.readObject());
}
2. NatCubic*Spline classes are not serializable so OMSpline fails
while serialization. This should help:
private transient NatCubicSpline natCubic = new NatCubicSpline();
private transient NatCubicClosedSpline natCubicClosed = new
NatCubicClosedSpline();
3. I have problem to achieve old OMDrawingTool functionality, when after
OMGraphic
selection attributes window was displayed imediately. Now I have to use
right mouse button
and choose option from PopUpMenu. It is OK but I'd like to know how change
this behavior.
4. In previous version I was able to change line rendering mode (Rhumb,
Great Circle,...)
for currently edited OMGraphic. Now "Drawing Tool" window is smaller, and
looks better,
but it hasn't combobox with rendering modes. I don't know if it is the aim
of changes,
or I just have to set some property to have this combobox visible?
As I can see you have changed appearance of "Drawing Tool" window to be
closer
to popular graphic programs (eg. Corel). It looks like floating toolbar and
I like it.
The line rendering mode combobox could be changed into three icons or even
togglebutton with three states. What do you think?
5. I've seen that you added EditableOMText to drawing tools. After
upgredeing
to current OpenMap version I've found that just after creating OMText
element
in DrawingToolLauncher, when user makes first click on a map, text is not
displayed.
If I keep mouse button pressed and move mouse a little the text appears.
The same problem is with my version of this class and your version.
Palette window for EditableOMText is rather ugly (I was in hurry while
writting this).
Now I can see that GUI similar to that offered by Microsoft Word toolbar
would be
better and nicer. If I find time I will change it.
A little bug: in cvs there is no "editabletext.gif" file. I've attached this
file.
6. In OMDrawingToolLauncher I preffer to have icons instead of OMGraphic
names.
I can set property for launcher to display icons but it uses JToolbar as a
container for them.
When there are many icons whole window becomes too wide and looks rather
ugly.
I preffer to have as small window as possible so I decided to put icons in
two rows.
To achieve that I subclass OMDrawingToolLauncher and change one method:
protected JComponent getToolWidgets(boolean useText) {
JPanel iconBar = new JPanel();
iconBar.setLayout(new GridLayout(2,4)); // this parameters should
be read from properties!
ButtonGroup bg = new ButtonGroup();
JToggleButton btn = null;
boolean setFirstButtonSelected = true;
Iterator graphicNames = loaders.keySet().iterator();
while (graphicNames.hasNext()) {
String pName = (String) graphicNames.next();
EditToolLoader etl = (EditToolLoader)loaders.get(pName);
ImageIcon icon = etl.getIcon(getEditableClassName(pName));
btn = new JToggleButton(icon);
btn.setMargin(new Insets(0,0,0,0));
btn.setToolTipText(pName);
btn.setActionCommand(pName);
btn.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent ae) {
setCurrentCreation(ae.getActionCommand());
}
});
if (setFirstButtonSelected) {
btn.setSelected(true);
setCurrentCreation(pName);
setFirstButtonSelected = false;
}
bg.add(btn);
iconBar.add(btn);
}
return iconBar;
}
There is nothing special in this method, but I think that this version could
be used in standard OMDrawingToolLauncher. Parameters for GridLayout
could be read from properties.
Hope to hear you soon.
Best regards,
Piotr
----- Original Message -----
From: "Don Dietrick" <dietrick@bbn.com>
To: "pitek" <Piotr.Kaminski@ctm.gdynia.pl>
Cc: <openmap-users@bbn.com>
Sent: Monday, November 03, 2003 4:28 PM
Subject: Re: [OpenMap Users] OpenMap Debug vs Log4J
> Hi Piotr,
>
> The main reason I like the idea of the Java Logging API is that it's
> built into the jdk. It does have the jdk 1.4 requirement, though,
> which OpenMap doesn't have (yet). I've heard many good things about
> log4j, too. We haven't really looked at the alternatives yet but
> thanks for the input, it matters and helps.
>
> Debug won't be changing for 4.6, though, we're going to make it a final
> release sometime next week. We're in the process of wrapping in some
> contributions (yours included) and last-minute API changes (projection
> factory, maybe some localization framework if possible).
>
> - Don
>
>
> On Nov 2, 2003, at 6:23 PM, pitek wrote:
>
> > Hi Don,
> > You wrote in one of your letters about using Java 1.4 Logging API
> > instead of Debug class. I think Debug class could be changed
> > for something else, but I'm not sure if Java Logging API is the
> > best one to use. In my project I'm going to use Log4Java.
> > I thought about using standard API but Log4J seems more
> > interesting to me especially after reading this article:
> > http://nagoya.apache.org/wiki/apachewiki.cgi?Log4JProjectPages/
> > Log4jvsJDKLogging
> > So, are you going to change Debug to something else in 4.6 release?
> > Regards,
> > Piotr Kaminski
>
-- [To unsubscribe to this list send an email to "majdart@bbn.com" with the following text in the BODY of the message "unsubscribe openmap-users"]
